wicket 1.2.7 login error checking and reporting

[Burton, Tom F (DOR)]

It works for Login Failures, and blank usernames. It just doesn't
work for blank passwords or blank username and password.

Why would the error() function work for user==null but not password==null?
My embarrassing log.debug line doesn't even fire, when there is no password.
Which is why I'm not sure whatever code the server runs once I hit submit doesn't get as far is this code without a password to verify.

Here is a code snippet:

form.add(new IndicatingAjaxSubmitButton("login", form)
{
private static final long serialVersionUID = 1L;
public void onSubmit(AjaxRequestTarget target, Form form)
{
//set user as a non myalaska user so it will log out to this page...
((QuickStartSession)getSession()).setMyAkUser(false);
User userLoggingIn = null;

target.addComponent(feedbackpanel);
target.addComponent(form);

String user_error = "'User Name' is a requied field";
String passwd_error = "'Password' is a required field";

//TODO: Delete this line once blank/empty passwd format verified
log.debug("Login AS: " + user + " : " + password);

if ( user == null && ( password == null ||
password.trim().equals("") ) )
{
error( user_error + "<br/>\n" + passwd_error );
}

else if (user == null)
{
//log.error("'User Name' is a requied field");
error( user_error );
//return;
}

else if (password == null || password.trim().equals("") )
{
log.error("'Passwd' is a requied field");
error( passwd_error );
//return;
}
//else { log.info("username and password entered."); }
//end the if else if block;

//end processing if username or password errors
if ( user == null || password == null
|| password.trim().equals("") )
{ return; }


Thanks for the help and patience,
Tom B.

-----Original Message-----
From: Igor Vaynberg [mailto:address-removed]
Sent: Friday, August 07, 2009 10:23 AM
To: Burton, Tom F (DOR)
Subject: Re: wicket 1.2.7 login error checking and reporting

right, there is no wicketfilter in 1.2.x, only wicketservlet.

if you get empty <ajaxresponse> back then maybe you are forgetting to
update the feedback panel using ajaxrequesttarget.

-igor

On Fri, Aug 7, 2009 at 11:08 AM, Burton, Tom F
(DOR)<address-removed> wrote:

[Melongo Annabel]

I don't know if this will be of any help, but instead of comparing if it's null or empty, try to use StringUtils.isEmpty( password ) ( same for username ) and see what you get. Here's an explanation of that method: http://commons.apache.org/lang/apidocs/org/apache/commons/lang/StringUtils.html#isEmpty(java.lang.String)


From: "Burton, Tom F (DOR)" <address-removed>
To: Igor Vaynberg <address-removed>
Cc: address-removed
Sent: Friday, August 7, 2009 1:47:03 PM
Subject: [nbusers] RE: wicket 1.2.7 login error checking and reporting

It works for Login Failures, and blank usernames. It just doesn't
work for blank passwords or blank username and password.

Why would the error() function work for user==null but not password==null?
My embarrassing log.debug line doesn't even fire, when there is no password.
Which is why I'm not sure whatever code the server runs once I hit submit doesn't get as far is this code without a password to verify.

Here is a code snippet:

form.add(new IndicatingAjaxSubmitButton("login", form)
{
private static final long serialVersionUID = 1L;
public void onSubmit(AjaxRequestTarget target, Form form)
{
//set user as a non myalaska user so it will log out to this page...
((QuickStartSession)getSession()).setMyAkUser(false);
User userLoggingIn = null;

target.addComponent(feedbackpanel);
target.addComponent(form);

String user_error = "'User Name' is a requied field";
String passwd_error = "'Password' is a required field";

//TODO: Delete this line once blank/empty passwd format verified
log.debug("Login AS: " + user + " : " + password);

if ( user == null && ( password == null ||
password.trim().equals("") ) )
{
error( user_error + "<br/>\n" + passwd_error );
}

else if (user == null)
{
//log.error("'User Name' is a requied field");
error( user_error );
//return;
}

else if (password == null || password.trim().equals("") )
{
log.error("'Passwd' is a requied field");
error( passwd_error );
//return;
}
//else { log.info("username and password entered."); }
//end the if else if block;

//end processing if username or password errors
if ( user == null || password == null
|| password.trim().equals("") )
{ return; }


Thanks for the help and patience,
Tom B.

-----Original Message-----
From: Igor Vaynberg [mailto:address-removed ([email]address-removed[/email])]
Sent: Friday, August 07, 2009 10:23 AM
To: Burton, Tom F (DOR)
Subject: Re: wicket 1.2.7 login error checking and reporting

right, there is no wicketfilter in 1.2.x, only wicketservlet.

if you get empty <ajaxresponse> back then maybe you are forgetting to
update the feedback panel using ajaxrequesttarget.

-igor

On Fri, Aug 7, 2009 at 11:08 AM, Burton, Tom F
(DOR)<address-removed ([email]address-removed[/email])> wrote: