NetBeans Forums

 FAQFAQ   SearchSearch   MemberlistMemberlist   RegisterRegister   ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 
  

Contribution pull request?

 
Post new topic   Reply to topic    NetBeans Forums -> NetBeans Developers
View previous topic :: View next topic  
Author Message
netbeans
Posted via mailing list.





PostPosted: Wed Jan 18, 2017 11:13 am    Post subject: Contribution pull request? Reply with quote

A while back I proposed a patch to an enhancement issue I created but
despite tagging, cc:ing, tweeting and emailing I haven't been able to
get any response at all on it. The Contributing Patches page,
https://netbeans.org/community/contribute/patches.html, is perhaps
incomplete?

Anyway the issue is
https://netbeans.org/bugzilla/show_bug.cgi?id=269050. I am looking
forward to the Apache infrastructure where I issue a PR and presumably
get it in the right person's queue to consider it.

Cheers,

Mike
Back to top
emi



Joined: 14 Aug 2009
Posts: 245

PostPosted: Wed Jan 18, 2017 1:27 pm    Post subject: Contribution pull request? Reply with quote

Yes, I remember your patch. I've also just subscribed to the issue.

The patch is quite clean, although I don't personally like the style it encourages.


Even if try and synchronized blocks are blocks, I really prefer the way the current NetBeans formatter wraps them in an explicit block.


So, I wonder if this is not the reason nobody hurried to include your patch.


It really does feel like a matter of preference so perhaps it should be hidden behind some flag?






--emi





On Wed, Jan 18, 2017 at 1:30 AM, <address-removed ([email]address-removed[/email])> wrote:
Quote:
A while back I proposed a patch to an enhancement issue I created but
despite tagging, cc:ing, tweeting and emailing I haven't been able to
get any response at all on it. The Contributing Patches page,
https://netbeans.org/community/contribute/patches.html, is perhaps
incomplete?

Anyway the issue is
https://netbeans.org/bugzilla/show_bug.cgi?id=269050. I am looking
forward to the Apache infrastructure where I issue a PR and presumably
get it in the right person's queue to consider it.

Cheers,

Mike
Back to top
Display posts from previous:   
Post new topic   Reply to topic    NetBeans Forums -> NetBeans Developers All times are GMT
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You can download files in this forum


Powered by phpBB
By use of this website, you agree to the NetBeans Policies and Terms of Use. © 2012, Oracle Corporation and/or its affiliates. Sponsored by Oracle logo